Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GFA crashes LeGo trialogs #177

Closed
szapp opened this issue Oct 4, 2017 · 2 comments
Closed

GFA crashes LeGo trialogs #177

szapp opened this issue Oct 4, 2017 · 2 comments

Comments

@szapp
Copy link
Owner

szapp commented Oct 4, 2017

During the second(?) call of TRIA_Next in a LeGo trialog the game crashes, because "this" has no valid visual in oCNpc::EV_PlayAni(oCMsgConversation *) 0x757AB0. This crash only happens with GFA_RANGED initialized and has only popped up recently.

Most likely, it is thus connected to the bounding box enlargement.

@szapp szapp added this to the v1.0.0 milestone Oct 4, 2017
@szapp szapp changed the title GFA crashes LeGo Trialogs GFA crashes LeGo trialogs Oct 4, 2017
@szapp
Copy link
Owner Author

szapp commented Oct 4, 2017

Similarly as the frame functions bug, this has to do with overwriting the variables of the backed up registers during a hook the calls another hooked function (see LeGo frame functions bug fix). There is no point, however, to do the same with every hook of LeGo (oCNPC::EV_PlayAni in this case), but instead the registers should be backed up on some sort of stack structure instead of overwriting their previous value.

@szapp
Copy link
Owner Author

szapp commented Oct 4, 2017

Preliminary fix for LeGo hooks is written, but needs to be tested thoroughly first, i.e. this bug will be fixed in LeGo, not here.

@szapp szapp closed this as completed Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant